Messages in this thread | | | Date | Fri, 19 Mar 2021 01:12:38 +0100 (CET) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig |
| |
On Thu, 18 Mar 2021, Christoph Hellwig wrote:
> sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless.
Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an IDE device, however the driver has supported libata ever since commit 2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver (v2)") back in 2008, so this is good to go. We should probably enable PATA_PLATFORM in the defconfig instead.
The printed name of the driver could be improved I suppose though:
scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36
(PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata).
Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>
Maciej
| |