Messages in this thread | | | From | Ilia Mirkin <> | Date | Thu, 18 Mar 2021 18:13:19 -0400 | Subject | Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: Check plane size for cursors, not fb size |
| |
On Thu, Mar 18, 2021 at 5:56 PM Lyude Paul <lyude@redhat.com> wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This is actually wrong though, as we only > want to be concerned that the actual width/height of the plane are the > same. It's fine if we scan out from an fb that's slightly larger than the > cursor plane (in fact, some igt tests actually do this).
How so? The scanout engine expects the data to be packed. Height can be larger, but width has to match.
-ilia
| |