Messages in this thread | | | From | Menglong Dong <> | Date | Wed, 17 Mar 2021 22:15:19 +0800 | Subject | Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_* |
| |
On Wed, Mar 17, 2021 at 9:53 PM Menglong Dong <menglong8.dong@gmail.com> wrote: > ... > > Seems that the inconsistent usages of 'msg_flags' is a lot, for example the > 'recvmsg()' in 'struct proto' and 'recvmsg()' in 'struct proto_ops': > > int (*recvmsg)(struct sock *sk, struct msghdr *msg, > size_t len, int noblock, int flags, > int *addr_len); > > This function prototype is used in many places, It's not easy to fix them. > This patch is already reverted, and I think maybe > I can resend it after I fix these 'int' flags. >
I doubt it now...there are hundreds of functions that are defined as 'proto_ops->recvmsg()'. enn...will this kind of patch be acceptable? Is it the time to give up?
With Best Regards, Menglong Dong
| |