Messages in this thread | | | Date | Wed, 17 Mar 2021 13:23:12 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2] smp: kernel/panic.c - silence warnings |
| |
On Wed, Mar 17, 2021 at 12:00:29PM +0100, Christophe Leroy wrote: > What do you mean ? 'extern' prototype is pointless for function prototypes > and deprecated, no new function prototypes should be added with the 'extern' > keyword. > > checkpatch.pl tells you: "extern prototypes should be avoided in .h files"
I have a very strong preference for extern on function decls, to match the extern on variable decl.
Checkpatch is just wrong here.
| |