Messages in this thread | | | Date | Wed, 17 Mar 2021 09:16:00 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle |
| |
On Sun, 14 Mar 2021, Marijn Suijten wrote:
> From: Obeida Shamoun <oshmoun100@googlemail.com> > > WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. > Therefore, use the sink address as base instead of the ctrl address. > > This fixes the sync toggle on wled4, which can be observed by the fact > that adjusting brightness now works. > > It has no effect on wled3 because sink and ctrl base addresses are the > same. This allows adjusting the brightness without having to disable > then reenable the module. > > Signed-off-by: Obeida Shamoun <oshmoun100@googlemail.com> > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |