lkml.org 
[lkml]   [2021]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/18] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/3w-sas.c: In function ‘twl_scsiop_execute_scsi’:
    drivers/scsi/3w-sas.c:298:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable]
    drivers/scsi/3w-sas.c: In function ‘twl_scsi_biosparam’:
    drivers/scsi/3w-sas.c:1411:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable]

    Cc: Adam Radford <aradford@gmail.com>
    Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
    Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
    Cc: linux-scsi@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/3w-sas.c | 10 ++--------
    1 file changed, 2 insertions(+), 8 deletions(-)

    diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
    index 3db0e42e9aa75..383f6f204c24b 100644
    --- a/drivers/scsi/3w-sas.c
    +++ b/drivers/scsi/3w-sas.c
    @@ -295,14 +295,11 @@ static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id,
    TW_Command_Apache *command_packet;
    int i, sg_count;
    struct scsi_cmnd *srb = NULL;
    - struct scatterlist *sglist = NULL, *sg;
    + struct scatterlist *sg;
    int retval = 1;

    - if (tw_dev->srb[request_id]) {
    + if (tw_dev->srb[request_id])
    srb = tw_dev->srb[request_id];
    - if (scsi_sglist(srb))
    - sglist = scsi_sglist(srb);
    - }

    /* Initialize command packet */
    full_command_packet = tw_dev->command_packet_virt[request_id];
    @@ -1408,9 +1405,6 @@ static int twl_reset_device_extension(TW_Device_Extension *tw_dev, int ioctl_res
    static int twl_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[])
    {
    int heads, sectors;
    - TW_Device_Extension *tw_dev;
    -
    - tw_dev = (TW_Device_Extension *)sdev->host->hostdata;

    if (capacity >= 0x200000) {
    heads = 255;
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-03-17 09:59    [W:2.295 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site