lkml.org 
[lkml]   [2021]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sched: swait: use wake_up_process() instead of wake_up_state()
    From
    Date
    On Tue, 2021-03-16 at 19:20 +0800, Wang Qing wrote:
    > Why not just use wake_up_process().

    IMO this is not an improvement. There are other places where explicit
    TASK_NORMAL is used as well, and they're all perfectly clear as is.

    > Signed-off-by: Wang Qing <wangqing@vivo.com>
    > ---
    > kernel/sched/swait.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/kernel/sched/swait.c b/kernel/sched/swait.c
    > index e1c655f..7a24925
    > --- a/kernel/sched/swait.c
    > +++ b/kernel/sched/swait.c
    > @@ -69,7 +69,7 @@ void swake_up_all(struct swait_queue_head *q)
    > while (!list_empty(&tmp)) {
    > curr = list_first_entry(&tmp, typeof(*curr), task_list);
    >
    > - wake_up_state(curr->task, TASK_NORMAL);
    > + wake_up_process(curr->task);
    > list_del_init(&curr->task_list);
    >
    > if (list_empty(&tmp))

    \
     
     \ /
      Last update: 2021-03-17 05:46    [W:3.182 / U:1.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site