Messages in this thread | | | Date | Wed, 17 Mar 2021 09:26:25 +0100 | From | Stefano Garzarella <> | Subject | Re: [PATCH] vhost: Fix vhost_vq_reset() |
| |
On Fri, Mar 12, 2021 at 03:09:13PM +0100, Laurent Vivier wrote: >vhost_reset_is_le() is vhost_init_is_le(), and in the case of >cross-endian legacy, vhost_init_is_le() depends on vq->user_be. > >vq->user_be is set by vhost_disable_cross_endian(). > >But in vhost_vq_reset(), we have: > > vhost_reset_is_le(vq); > vhost_disable_cross_endian(vq); > >And so user_be is used before being set. > >To fix that, reverse the lines order as there is no other dependency >between them. > >Signed-off-by: Laurent Vivier <lvivier@redhat.com> >--- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
| |