Messages in this thread | | | Date | Wed, 17 Mar 2021 09:12:15 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 5/9] objtool: Rework rebuild_reloc logic |
| |
On Tue, Mar 16, 2021 at 10:34:17PM -0500, Josh Poimboeuf wrote: > On Fri, Mar 12, 2021 at 06:16:18PM +0100, Peter Zijlstra wrote: > > --- a/tools/objtool/elf.c > > +++ b/tools/objtool/elf.c > > @@ -479,6 +479,8 @@ void elf_add_reloc(struct elf *elf, stru > > > > list_add_tail(&reloc->list, &sec->reloc_list); > > elf_hash_add(elf->reloc_hash, &reloc->hash, reloc_hash(reloc)); > > + > > + sec->rereloc = true; > > } > > Can we just reuse sec->changed for this? Something like this on top > (untested of course):
I think my worry was that we'd dirty too much and slow down the write, but I haven't done any actual performance measurements on this.
Let me do a few runs and see if it matters at all.
| |