Messages in this thread | | | Subject | Re: [PATCH] sched: replace if (cond) BUG() with BUG_ON() | From | Christophe Leroy <> | Date | Wed, 17 Mar 2021 08:00:57 +0100 |
| |
Le 17/03/2021 à 07:45, Jiapeng Chong a écrit : > Fix the following coccicheck warnings: > > ./arch/powerpc/platforms/cell/spufs/sched.c:908:2-5: WARNING: Use BUG_ON > instead of if condition followed by BUG.
Consider using WARN_ON() instead of BUG_ON() if relevant. If not, explain in the commit message why we need to keep a BUG_ON().
See https://www.kernel.org/doc/html/latest/process/deprecated.html#bug-and-bug-on
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > arch/powerpc/platforms/cell/spufs/sched.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c > index 3692064..139a6ec 100644 > --- a/arch/powerpc/platforms/cell/spufs/sched.c > +++ b/arch/powerpc/platforms/cell/spufs/sched.c > @@ -904,8 +904,7 @@ static noinline void spusched_tick(struct spu_context *ctx) > struct spu_context *new = NULL; > struct spu *spu = NULL; > > - if (spu_acquire(ctx)) > - BUG(); /* a kernel thread never has signals pending */ > + BUG_ON(spu_acquire(ctx)); /* a kernel thread never has signals pending */ > > if (ctx->state != SPU_STATE_RUNNABLE) > goto out; >
| |