Messages in this thread | | | Subject | Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings | From | "heying (H)" <> | Date | Thu, 18 Mar 2021 10:37:26 +0800 |
| |
在 2021/3/17 19:57, Michael Ellerman 写道: > Daniel Axtens <dja@axtens.net> writes: >> "heying (H)" <heying24@huawei.com> writes: >> >>> Thank you for your reply. >>> >>> 在 2021/3/17 11:04, Daniel Axtens 写道: >>>> Hi He Ying, >>>> >>>> Thank you for this patch. >>>> >>>> I'm not sure what the precise rules for Fixes are, but I wonder if this >>>> should have: >>>> >>>> Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") >>>> Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry") >>> Is that necessary for warning cleanups? I thought 'Fixes' tags are >>> needed only for >>> >>> bugfix patches. Can someone tell me whether I am right? >> Yeah, I'm not sure either. Hopefully mpe will let us know. > It's not necessary to add a Fixes tag for a patch like this, but you can > add one if you think it's important that the fix gets backported. > > I don't think the cleanups in this case are that important, so I > wouldn't bother with a Fixes tag. Okay. That's a good explanation to me. Thanks.
| |