Messages in this thread | | | Date | Wed, 17 Mar 2021 11:47:01 -0700 | From | Jakub Kicinski <> | Subject | Re: [net PATCH 4/9] octeontx2-af: Remove TOS field from MKEX TX |
| |
On Wed, 17 Mar 2021 12:07:12 +0530 sundeep subbaraya wrote: > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > > On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote: > > > From: Subbaraya Sundeep <sbhatta@marvell.com> > > > > > > TOS overlaps with DMAC field in mcam search key and hence installing > > > rules for TX side are failing. Hence remove TOS field from TX profile. > > > > Could you clarify what "installing rules is failing" means? > > Return error or does not behave correctly? > > Returns error. The MKEX profile can be in a way where higher layer packet fields > can overwrite lower layer packet fields in output MCAM Key. The commit > 42006910 ("octeontx2-af: cleanup KPU config data") introduced TX TOS field and > it overwrites DMAC. AF driver return error when TX rule is installed > with DMAC as > match criteria since DMAC gets overwritten and cannot be supported. Layers from > lower to higher in our case: > LA - Ethernet > LB - VLAN > LC - IP > LD - TCP/UDP > and so on. > > We make sure there are no overlaps between layers but TOS got added by mistake. > We will elaborate the commit description and send the next version.
Thank you! The longer explanation makes the error clear.
| |