lkml.org 
[lkml]   [2021]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] smp: kernel/panic.c - silence warnings
    From
    Date


    Le 17/03/2021 à 13:23, Peter Zijlstra a écrit :
    > On Wed, Mar 17, 2021 at 12:00:29PM +0100, Christophe Leroy wrote:
    >> What do you mean ? 'extern' prototype is pointless for function prototypes
    >> and deprecated, no new function prototypes should be added with the 'extern'
    >> keyword.
    >>
    >> checkpatch.pl tells you: "extern prototypes should be avoided in .h files"
    >
    > I have a very strong preference for extern on function decls, to match
    > the extern on variable decl.

    You mean you also do 'static inline' variable declarations ?

    I think you just can't compare variable declarations and function declaration, that's too different.

    >
    > Checkpatch is just wrong here.
    >

    checkpatch seems rather pragmatic, the commit message says:

    checkpatch: warn when using extern with function prototypes in .h files

    Using the extern keyword on function prototypes is superfluous visual
    noise so suggest removing it.

    Using extern can cause unnecessary line wrapping at 80 columns and
    unnecessarily long multi-line function prototypes.

    Signed-off-by: Joe Perches <joe@perches.com>
    Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

    \
     
     \ /
      Last update: 2021-03-17 18:20    [W:2.681 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site