lkml.org 
[lkml]   [2021]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code
    On Tue, Mar 16, 2021 at 02:20:27PM +0200, Mihai Carabas wrote:
    > +#ifdef pr_fmt
    > +#undef pr_fmt
    > +#endif
    > +
    > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

    This isn't even needed given you do not have any pr_* calls in this
    code. As you shouldn't this is driver stuff, you should always use the
    dev_* calls instead.

    But you can delete that later, this is fine for now. However generally
    you do not set this value in a .h file, but rather in the individual .c
    files if you really need it.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2021-03-16 17:47    [W:3.923 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site