Messages in this thread | | | Date | Tue, 16 Mar 2021 15:46:22 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C |
| |
On Tue, Mar 16, 2021 at 12:52:51PM +0100, Henning Schild wrote: > Am Tue, 16 Mar 2021 13:30:36 +0200 > schrieb Andy Shevchenko <andriy.shevchenko@intel.com>: > > > On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote: > > > From: Johannes Hahn <johannes-hahn@siemens.com> > > > > > > This allows the RX6110 driver to be automatically assigned to the > > > right device on the I2C bus. > > > > Thanks for all effort! > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> > > after addressing the below comments. > > > > > Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com> > > > Signed-off-by: Claudius Heine <ch@denx.de> > > > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > Claudius, just remove that. I guess just add yours and mention authors > in the code if they should receive some recognition.
> > > +#ifdef CONFIG_ACPI > > > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = { > > > + { "SECC6110", },
> > > + { },
Missed one thing, remove comma here. Terminator lines do not need a comma (and it's theoretically may confuse people or scripts while adding a new record to the array).
> > > +}; > > > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match); > > > +#endif
-- With Best Regards, Andy Shevchenko
| |