lkml.org 
[lkml]   [2021]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM
    On Tue, Mar 16, 2021 at 12:39:19PM +0100, Greg KH wrote:
    > On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote:
    > > remove conditional code blocks checked by unused CONFIG_PM
    > >
    > > cleaning required in TODO file:
    > >
    > > find and remove code blocks guarded by never set CONFIG_FOO defines
    > >
    > > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
    > > ---
    > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 --------
    > > 1 file changed, 8 deletions(-)
    > >
    > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
    > > index 2ff71d001c07..5748e1c1a25c 100644
    > > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
    > > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
    > > @@ -3198,14 +3198,6 @@ static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w
    > > wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
    > > wiphy->flags |= WIPHY_FLAG_OFFCHAN_TX | WIPHY_FLAG_HAVE_AP_SME;
    > >
    > > -#if defined(CONFIG_PM)
    > > - wiphy->max_sched_scan_reqs = 1;
    > > -#endif
    > > -
    > > -#if defined(CONFIG_PM)
    > > - wiphy->wowlan = &wowlan_stub;
    > > -#endif
    >
    > How this is "unused"? This is a real config option, did you just change
    > the logic here?
    >
    > thanks,
    >
    > greg k-h

    Hi Greg,

    ignore this patch. I missed that definition of PM config option.
    I dropped it off my own local repo.

    Thank you,

    fabio

    \
     
     \ /
      Last update: 2021-03-16 14:37    [W:3.963 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site