Messages in this thread | | | Subject | Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings | From | Christophe Leroy <> | Date | Tue, 16 Mar 2021 07:57:38 +0100 |
| |
Le 16/03/2021 à 05:11, He Ying a écrit : > warning: symbol 'rfi_flush' was not declared. > warning: symbol 'entry_flush' was not declared. > warning: symbol 'uaccess_flush' was not declared. > We found warnings above in arch/powerpc/kernel/setup_64.c by using > sparse tool. > > Define 'entry_flush' and 'uaccess_flush' as static because they are not > referenced outside the file. Include asm/security_features.h in which > 'rfi_flush' is declared. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: He Ying <heying24@huawei.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> --- > arch/powerpc/kernel/setup_64.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 560ed8b975e7..f92d72a7e7ce 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -68,6 +68,7 @@ > #include <asm/early_ioremap.h> > #include <asm/pgalloc.h> > #include <asm/asm-prototypes.h> > +#include <asm/security_features.h> > > #include "setup.h" > > @@ -949,8 +950,8 @@ static bool no_rfi_flush; > static bool no_entry_flush; > static bool no_uaccess_flush; > bool rfi_flush; > -bool entry_flush; > -bool uaccess_flush; > +static bool entry_flush; > +static bool uaccess_flush; > DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); > EXPORT_SYMBOL(uaccess_flush_key); > >
| |