lkml.org 
[lkml]   [2021]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.11 13/61] net: tehuti: fix error return code in bdx_probe()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ]

    When bdx_read_mac() fails, no error return code of bdx_probe()
    is assigned.
    To fix this bug, err is assigned with -EFAULT as error return code.

    Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/tehuti/tehuti.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c
    index b8f4f419173f..d054c6e83b1c 100644
    --- a/drivers/net/ethernet/tehuti/tehuti.c
    +++ b/drivers/net/ethernet/tehuti/tehuti.c
    @@ -2044,6 +2044,7 @@ bdx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    /*bdx_hw_reset(priv); */
    if (bdx_read_mac(priv)) {
    pr_err("load MAC address failed\n");
    + err = -EFAULT;
    goto err_out_iomap;
    }
    SET_NETDEV_DEV(ndev, &pdev->dev);
    --
    2.30.1
    \
     
     \ /
      Last update: 2021-03-17 01:59    [W:2.436 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site