Messages in this thread | | | Date | Tue, 16 Mar 2021 14:21:13 -0700 | From | Jakub Kicinski <> | Subject | Re: [RESEND v1 net-next 2/5] net: stmmac: make stmmac_interrupt() function more friendly to MSI |
| |
On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote: > + if (unlikely(!dev)) { > + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__); > + return IRQ_NONE; > + }
Where did this check come from? Please avoid defensive programming in the kernel unless you can point out how the condition can arise legitimately.
| |