lkml.org 
[lkml]   [2021]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND v1 net-next 2/5] net: stmmac: make stmmac_interrupt() function more friendly to MSI
On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote:
> + if (unlikely(!dev)) {
> + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__);
> + return IRQ_NONE;
> + }

Where did this check come from? Please avoid defensive programming
in the kernel unless you can point out how the condition can arise
legitimately.

\
 
 \ /
  Last update: 2021-03-16 22:22    [W:0.182 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site