lkml.org 
[lkml]   [2021]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 33/95] mmc: mxs-mmc: Fix a resource leak in an error handling path in mxs_mmc_probe()
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 0bb7e560f821c7770973a94e346654c4bdccd42c ]

    If 'mmc_of_parse()' fails, we must undo the previous 'dma_request_chan()'
    call.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20201208203527.49262-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/mxs-mmc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
    index add1e70195ea..7125687faf76 100644
    --- a/drivers/mmc/host/mxs-mmc.c
    +++ b/drivers/mmc/host/mxs-mmc.c
    @@ -659,7 +659,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)

    ret = mmc_of_parse(mmc);
    if (ret)
    - goto out_clk_disable;
    + goto out_free_dma;

    mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;

    --
    2.30.1


    \
     
     \ /
      Last update: 2021-03-15 15:39    [W:4.430 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site