lkml.org 
[lkml]   [2021]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 09/17] ASoC: tegra20: i2s: Correct driver removal order
    Date
    Tegra20 I2S driver has a wrong driver removal order, which should be
    opposite to the registration order, but it's not. In particular the
    runtime PM is disabled in a wrong order. Fix the order.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    sound/soc/tegra/tegra20_i2s.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/sound/soc/tegra/tegra20_i2s.c b/sound/soc/tegra/tegra20_i2s.c
    index 267517446d27..0f2bdc2e8598 100644
    --- a/sound/soc/tegra/tegra20_i2s.c
    +++ b/sound/soc/tegra/tegra20_i2s.c
    @@ -440,13 +440,13 @@ static int tegra20_i2s_platform_remove(struct platform_device *pdev)
    {
    struct tegra20_i2s *i2s = dev_get_drvdata(&pdev->dev);

    + tegra_pcm_platform_unregister(&pdev->dev);
    + snd_soc_unregister_component(&pdev->dev);
    +
    pm_runtime_disable(&pdev->dev);
    if (!pm_runtime_status_suspended(&pdev->dev))
    tegra20_i2s_runtime_suspend(&pdev->dev);

    - tegra_pcm_platform_unregister(&pdev->dev);
    - snd_soc_unregister_component(&pdev->dev);
    -
    clk_put(i2s->clk_i2s);

    return 0;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-03-14 16:47    [W:2.762 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site