lkml.org 
[lkml]   [2021]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
On Sat, 13 Mar 2021 12:17:34 +0100
Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:

> On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> > On Mon, 08 Mar 2021, Andreas Kemnade wrote:
> [...]
> > > -static const struct mfd_cell ntxec_subdevices[] = {
> > > +static const struct mfd_cell ntxec_subdev[] = {
> > > { .name = "ntxec-rtc" },
> > > { .name = "ntxec-pwm" },
> > > };
> > >
> > > +static const struct mfd_cell ntxec_subdev_pwm[] = {
> > > + { .name = "ntxec-pwm" },
> > > +};
> >
> > To put across what you're trying to achieve, maybe call this:
> >
> > ntxec_subdev_no_rtc[]
> >
> > Then if other devices are added, the semantics/intent stays the same
> > and it won't have to be renamed.
>
> Andreas, what is the full amount of functionality this version of the EC
> can ever provide?
>
> If it's only PWM, I think ntxec_subdev_pwm fits well.
>
I think it is only PWM. At least I could not see any other I2C access.

> [ The next subdevice that I can foresee is battery monitoring. ]
>
That is done via the RC5T619 on that device.

Regards,
Andreas

\
 
 \ /
  Last update: 2021-03-13 16:09    [W:0.054 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site