Messages in this thread | | | Subject | Re: [PATCH 1/4] KVM: x86/mmu: Fix RCU usage in handle_removed_tdp_mmu_page | From | Paolo Bonzini <> | Date | Fri, 12 Mar 2021 16:43:21 +0100 |
| |
On 12/03/21 16:37, Sean Christopherson wrote: > On Thu, Mar 11, 2021, Ben Gardon wrote: >> The pt passed into handle_removed_tdp_mmu_page does not need RCU >> protection, as it is not at any risk of being freed by another thread at >> that point. However, the implicit cast from tdp_sptep_t to u64 * dropped >> the __rcu annotation without a proper rcu_derefrence. Fix this by >> passing the pt as a tdp_ptep_t and then rcu_dereferencing it in >> the function. >> >> Suggested-by: Sean Christopherson <seanjc@google.com> >> Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Should be <lkp@intel.com>. Looks like you've been taking pointers from Paolo :-)
The day someone starts confusing employers in CCs you should tell them "I see you have constructed a new email sending alias. Your skills are now complete".
Paolo
> https://lkml.org/lkml/2019/6/17/1210 > > Other than that, > > Reviewed-by: Sean Christopherson <seanjc@google.com> > >> Signed-off-by: Ben Gardon <bgardon@google.com> >
| |