Messages in this thread | | | Subject | Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static | From | Cédric Le Goater <> | Date | Fri, 12 Mar 2021 14:33:39 +0100 |
| |
On 3/12/21 12:06 PM, He Ying wrote: > The variable 'uaccess_fulsh' is not referenced outside the file. Perhaps we > should define it as static to avoid the warning as follows: > > arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' > was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: He Ying <heying24@huawei.com> > --- > arch/powerpc/kernel/setup_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 560ed8b975e7..22aca271496b 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -950,7 +950,7 @@ static bool no_entry_flush; > static bool no_uaccess_flush; > bool rfi_flush; > bool entry_flush;
I think this is the case also for entry_flush. compiling with W=1 will tell you more.
Thanks,
C.
> -bool uaccess_flush; > +static bool uaccess_flush; > DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); > EXPORT_SYMBOL(uaccess_flush_key); > >
| |