Messages in this thread | | | Date | Fri, 12 Mar 2021 12:57:57 +0100 | From | David Sterba <> | Subject | Re: [PATCH 0/3] btrfs: Convert kmap/memset/kunmap to memzero_user() |
| |
On Thu, Mar 11, 2021 at 07:57:48AM -0800, Ira Weiny wrote: > On Wed, Mar 10, 2021 at 03:58:36PM -0800, Andrew Morton wrote: > > On Tue, 9 Mar 2021 13:21:34 -0800 ira.weiny@intel.com wrote: > > > > > Previously this was submitted to convert to zero_user()[1]. zero_user() is not > > > the same as memzero_user() and in fact some zero_user() calls may be better off > > > as memzero_user(). Regardless it was incorrect to convert btrfs to > > > zero_user(). > > > > > > This series corrects this by lifting memzero_user(), converting it to > > > kmap_local_page(), and then using it in btrfs. > > > > This impacts btrfs more than MM. I suggest the btrfs developers grab > > it, with my > > I thought David wanted you to take these this time? > > "I can play the messenger again but now it seems a round of review is needed > and with some testing it'll be possible in some -rc. At that point you may take > the patches via the mm tree, unless Linus is ok with a late pull." > > -- https://lore.kernel.org/lkml/20210224123049.GX1993@twin.jikos.cz/ > > But reading that again I'm not sure what he meant.
As Linus had some objections I was not sure it was still feasible for the merge window, but this is now sorted. This new patchset does further changes in MM and the btrfs part is a straightforward cleanup. I've noticed Andrew added the patches to his queue which I'd prefer so I've added my reviewed-by to the third patch. Thanks.
| |