Messages in this thread | | | Subject | Re: [PATCH v5 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible | From | Rafał Miłecki <> | Date | Fri, 12 Mar 2021 07:15:22 +0100 |
| |
On 11.03.2021 11:50, Ansuel Smith wrote: > On Thu, Mar 11, 2021 at 10:32:21AM -0700, Rob Herring wrote: >> On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote: >>> Document nvmem-cells compatible used to treat mtd partitions as a >>> nvmem provider. >>> >>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> >>> --- >>> .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++ >>> 1 file changed, 99 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml >>> new file mode 100644 >>> index 000000000000..b53faf87d4e4 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml >>> @@ -0,0 +1,99 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Nvmem cells >>> + >>> +description: | >>> + Any partition containing the compatible "nvmem-cells" will register as a >>> + nvmem provider. >>> + Each direct subnodes represents a nvmem cell following the nvmem binding. >>> + Nvmem binding to declare nvmem-cells can be found in: >>> + Documentation/devicetree/bindings/nvmem/nvmem.yaml >>> + >>> +maintainers: >>> + - Ansuel Smith <ansuelsmth@gmail.com> >>> + >>> +allOf: >>> + - $ref: "../../nvmem/nvmem.yaml#" >> >> I'd rather have the 'absolute' path: >> >> /schemas/nvmem/nvmem.yaml >> >> Otherwise, >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> > > Should I send a v7?
Yes, please, let's make it the right way :)
When sending V7 please:
1. Include above "Reviewed-by" in the "dt-bindings: mtd: Document use of nvmem-cells compatible"
2. Include my "Tested-by" in the "mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells" Reference: [PATCH v2 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells https://patchwork.ozlabs.org/project/linux-mtd/patch/20210216212638.28382-3-ansuelsmth@gmail.com/
| |