Messages in this thread | | | Subject | Re: [PATCH] clk: socfpga: fix iomem pointer cast on 64-bit | From | Dinh Nguyen <> | Date | Thu, 11 Mar 2021 10:03:37 -0600 |
| |
On 3/11/21 8:48 AM, Krzysztof Kozlowski wrote: > Pointers should be cast to unsigned long instead of integer. This fixes > warning when compile testing on ARM64: > > drivers/clk/socfpga/clk-gate.c: In function ‘socfpga_clk_recalc_rate’: > drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > drivers/clk/socfpga/clk-gate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c > index 43ecd507bf83..c876523d5d51 100644 > --- a/drivers/clk/socfpga/clk-gate.c > +++ b/drivers/clk/socfpga/clk-gate.c > @@ -99,7 +99,7 @@ static unsigned long socfpga_clk_recalc_rate(struct clk_hw *hwclk, > val = readl(socfpgaclk->div_reg) >> socfpgaclk->shift; > val &= GENMASK(socfpgaclk->width - 1, 0); > /* Check for GPIO_DB_CLK by its offset */ > - if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET) > + if ((unsigned long) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET) > div = val + 1; > else > div = (1 << val); >
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
| |