Messages in this thread | | | Subject | Re: [PATCH v22 8/8] x86/vdso: Add ENDBR64 to __vdso_sgx_enter_enclave | From | "Yu, Yu-cheng" <> | Date | Thu, 11 Mar 2021 07:44:39 -0800 |
| |
On 3/11/2021 12:42 AM, Peter Zijlstra wrote: > On Thu, Mar 11, 2021 at 05:36:06AM +0200, Jarkko Sakkinen wrote: >> Does it do any harm to put it there unconditionally? > > Blows up your text footprint and I$ pressure. These instructions are 4 > bytes each. > > Aside from that, they're a NOP, so only consume front-end resources > (hopefully) on older CPUs and when IBT is disabled. >
Thanks Peter. I think probably we'll do the macro Boris suggested. That takes care of the visual clutter, and eliminates the need of using .byte when the assembler is outdated.
-- Yu-cheng
| |