lkml.org 
[lkml]   [2021]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries.
On Thu, 11 Mar 2021 15:02:16 +0100,
Andy Shevchenko wrote:
>
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > > No functional change implied.
> >
> > I'd love to apply this kind of cleanups (and I do sometimes
> > partially), but practically seen, this may make the stable backporting
> > significantly harder because many quirk patches are backported to the
> > very old LTS kernels. So, unless any specific reason (e.g. some
> > entries doubled or wrongly applied) is given, I'd avoid this full
> > plastic surgery.
>
> Can we ask people to follow the ordering before patches were applied?

Yeah, I should apply more strict check in my side in future, too.


Takashi

\
 
 \ /
  Last update: 2021-03-11 15:08    [W:0.848 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site