Messages in this thread | | | Date | Thu, 11 Mar 2021 07:43:36 +0100 | From | Philipp Zabel <> | Subject | Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver |
| |
Hi Cristian,
On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote: > Add new driver for the Ethernet MAC used on the Actions Semi Owl > family of SoCs. > > Currently this has been tested only on the Actions Semi S500 SoC > variant. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> > --- [...] > diff --git a/drivers/net/ethernet/actions/owl-emac.c b/drivers/net/ethernet/actions/owl-emac.c > new file mode 100644 > index 000000000000..ebd8ea88bca4 > --- /dev/null > +++ b/drivers/net/ethernet/actions/owl-emac.c > @@ -0,0 +1,1660 @@ [...] > +static int owl_emac_probe(struct platform_device *pdev) > +{ [...] > + priv->reset = devm_reset_control_get(dev, NULL);
Please use
priv->reset = devm_reset_control_get_exclusive(dev, NULL);
instead, to explicitly state that the driver requires exclusive control over the reset line.
> + if (IS_ERR(priv->reset)) { > + ret = PTR_ERR(priv->reset); > + dev_err(dev, "failed to get reset control: %d\n", ret); > + return ret;
You could use:
return dev_err_probe(dev, PTR_ERR(priv->reset), "failed to get reset control");
regards Philipp
| |