Messages in this thread | | | From | Masahiro Yamada <> | Date | Thu, 11 Mar 2021 19:33:42 +0900 | Subject | Re: [PATCH] kbuild: collect minimum tool versions into scripts/min-tool-version.sh |
| |
On Thu, Mar 11, 2021 at 7:18 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Thu, Mar 11, 2021 at 10:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > +# When you raise the minimum version, please update > > +# Documentation/process/changes.rst as well. > > +min_gcc_version=4.9.0 > > +min_llvm_version=10.0.1 > > +min_icc_version=16.0.3 # temporary > > +min_binutils_version=2.23.0 > > +1 to creating a central place for all minimum versions. > > Acked-by: Miguel Ojeda <ojeda@kernel.org> > > I wonder if you considered creating a folder with files like > `scripts/min_versions/gcc` containing the version string. That would > make it easier for reading from other languages or even importing them > dynamically into the documentation, thus removing even more > duplication. > > Cheers, > Miguel
Hmm, that is a simple, clean idea. Then, we can simply read out the file
$ cat scripts/min_versions/gcc 4.9.0
I do not know how to handle per-arch versions in this case.
Or, we might need to stick to shell-scripting to handle this.
scripts/min_versions/gcc #!/bin/sh # SPDX-License-Identifier: GPL-2.0-only if [ "$SRCARCH" = arm64 ]; then echo 5.1.0 else echo 4.9.0 fi
-- Best Regards Masahiro Yamada
| |