Messages in this thread | | | Date | Fri, 12 Mar 2021 11:10:26 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] bootconfig: Update prototype of setup_boot_config() |
| |
On Thu, 11 Mar 2021 09:03:21 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 11 Mar 2021 16:52:13 +0800 > Cao jin <jojing64@gmail.com> wrote: > > > Parameter "cmdline" has no use, drop it. > > Actually, I wonder if it should be using that instead of boot_command_line, > as the cmdline passed in is boot_command_line plus anything that the > architecture itself modified. > > Masami?
I think the policy is that boot_command_line is the reference command line string passed from user, and the passed cmdline is modified by architecutre code. But those are usually same in most cases, because boot_command_line was also modified in setup_arch().
For example, x86 setup_arch() overwrites/modifies boot_command_line itself by builtin_cmdline, and copy boot_command_line into the passed cmdline.
Thank you,
-- Masami Hiramatsu <mhiramat@kernel.org>
| |