lkml.org 
[lkml]   [2021]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V11 0/5] dt: Add fdtoverlay rule and statically build unittest
From
Date
On 3/9/21 11:35 PM, Viresh Kumar wrote:
> Hi,
>
> This patchset adds a generic rule for applying overlays using fdtoverlay
> tool and then updates unittests to get built statically using the same.
>
> V10->V11:
> - Update patch 4/5 to fix checkpatch warning on spaces and tabs.
> - Added Acked-by from Masahiro for patch 2/5.
>
> V9->V10:
> - Add a new patch to allow .dtso files.
> - Update 2/5 to be more efficient and also generate symbols for base
> files automatically.
> - No need to add lines like DTC_FLAGS_foo_base += -@ in patch 5/5.
> - Add Ack by Masahiro for 1/5.
>
> V8->V9:
> - Added some comment in patch 3/4 based on Frank's suggestions.
>
> V7->V8:
> - Patch 1 is new.
> - Platforms need to use dtb-y += foo.dtb instead of overlay-y +=
> foo.dtb.
> - Use multi_depend instead of .SECONDEXPANSION.
> - Use dtb-y for unittest instead of overlay-y.
> - Rename the commented dtb filess in unittest Makefile as .dtbo.
> - Improved Makefile code (I am learning a lot every day :)
>
> V6->V7:
> - Dropped the first 4 patches, already merged.
> - Patch 1/3 is new, suggested by Rob and slightly modified by me.
> - Adapt Patch 3/3 to the new rule and name the overlay dtbs as .dtbo.
>
> --
> Viresh
>
> Rob Herring (1):
> kbuild: Add generic rule to apply fdtoverlay
>
> Viresh Kumar (4):
> kbuild: Simplify builds with CONFIG_OF_ALL_DTBS
> kbuild: Allow .dtso format for overlay source files
> of: unittest: Create overlay_common.dtsi and testcases_common.dtsi
> of: unittest: Statically apply overlays using fdtoverlay
>
> drivers/of/unittest-data/Makefile | 48 ++++++++++
> drivers/of/unittest-data/overlay_base.dts | 90 +-----------------
> drivers/of/unittest-data/overlay_common.dtsi | 91 +++++++++++++++++++
> drivers/of/unittest-data/static_base_1.dts | 4 +
> drivers/of/unittest-data/static_base_2.dts | 4 +
> drivers/of/unittest-data/testcases.dts | 23 ++---
> .../of/unittest-data/testcases_common.dtsi | 19 ++++
> .../of/unittest-data/tests-interrupts.dtsi | 11 +--
> scripts/Makefile.lib | 40 ++++++--
> 9 files changed, 218 insertions(+), 112 deletions(-)
> create mode 100644 drivers/of/unittest-data/overlay_common.dtsi
> create mode 100644 drivers/of/unittest-data/static_base_1.dts
> create mode 100644 drivers/of/unittest-data/static_base_2.dts
> create mode 100644 drivers/of/unittest-data/testcases_common.dtsi
>
>
> base-commit: a38fd8748464831584a19438cbb3082b5a2dab15
>

Does not apply to 5.12-rc2 because of a dependency on a patch to
scripts/Makefile.lib. That patch has been merged by Linus
somewhere between -rc2 and -rc3. I had a working version
between -rc2 and -rc3 at commit e6f197677b2e that does have
the required patch, so that is the version I used to test
this series.

There is still confusion caused by the contortions that unittest
goes through to mis-use base DTBs vs overlay DTBs, so _after_
this series is merged by Rob, I will poke around and see if
I can change unittest so that it does not look like it is
mis-using DTBs and overlay DTBs.


Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Tested-by: Frank Rowand <frank.rowand@sony.com>


\
 
 \ /
  Last update: 2021-03-12 00:28    [W:0.167 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site