lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V2 16/25] perf/x86: Register hybrid PMUs
    From
    Date
    On 3/10/21 8:37 AM, kan.liang@linux.intel.com wrote:
    > - err = perf_pmu_register(&pmu, "cpu", PERF_TYPE_RAW);
    > - if (err)
    > - goto out2;
    > + if (!is_hybrid()) {
    > + err = perf_pmu_register(&pmu, "cpu", PERF_TYPE_RAW);
    > + if (err)
    > + goto out2;
    > + } else {
    > + u8 cpu_type = get_hybrid_cpu_type(smp_processor_id());
    > + struct x86_hybrid_pmu *hybrid_pmu;
    > + int i;

    Where's the preempt_disable()?

    > +static void init_hybrid_pmu(int cpu)
    > +{
    > + unsigned int fixed_mask, unused_eax, unused_ebx, unused_edx;
    > + struct cpu_hw_events *cpuc = &per_cpu(cpu_hw_events, cpu);
    > + u8 cpu_type = get_hybrid_cpu_type(cpu);
    > + struct x86_hybrid_pmu *pmu = NULL;
    > + struct perf_cpu_context *cpuctx;
    > + int i;

    Ditto.

    Are we really sure the IPIs are worth the trouble? Why don't we just
    cache the leaf when we bring the CPU up like just about every other
    thing we read from CPUID?

    \
     
     \ /
      Last update: 2021-03-10 17:52    [W:3.111 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site