Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v3 1/3] scsi: ufshcd: use a function to calculate versions | Date | Wed, 10 Mar 2021 16:34:32 +0000 |
| |
> @@ -9298,10 +9291,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > *mmio_base, unsigned int irq) > /* Get UFS version supported by the controller */ > hba->ufs_version = ufshcd_get_ufs_version(hba); > > - if ((hba->ufs_version != UFSHCI_VERSION_10) && > - (hba->ufs_version != UFSHCI_VERSION_11) && > - (hba->ufs_version != UFSHCI_VERSION_20) && > - (hba->ufs_version != UFSHCI_VERSION_21)) > + if (hba->ufs_version < ufshci_version(1, 0)) > dev_err(hba->dev, "invalid UFS version 0x%x\n", > hba->ufs_version); Here you replaces the specific allowable values, with an expression That doesn't really reflects those values.
| |