lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags
On Sun, Feb 28, 2021 at 6:08 PM DENG Qingfang <dqfext@gmail.com> wrote:

> Commit 86dd9868b878 has several issues, but was accepted too soon
> before anyone could take a look.
>
> - Double free. dsa_slave_xmit() will free the skb if the xmit function
> returns NULL, but the skb is already freed by eth_skb_pad(). Use
> __skb_put_padto() to avoid that.
> - Unnecessary allocation. It has been done by DSA core since commit
> a3b0b6479700.
> - A u16 pointer points to skb data. It should be __be16 for network
> byte order.
> - Typo in comments. "numer" -> "number".
>
> Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>

Ooops I send patches before properly going through the mailbox.
Oh well things like that happen.

David: ignore my patches to the same tagger and apply this instead!

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2021-03-01 15:02    [W:0.041 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site