lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 591/775] USB: serial: mos7720: fix error code in mos7720_write()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit fea7372cbc40869876df0f045e367f6f97a1666c upstream.

    This code should return -ENOMEM if the kmalloc() fails but instead
    it returns success.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
    Cc: stable@vger.kernel.org
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/serial/mos7720.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/serial/mos7720.c
    +++ b/drivers/usb/serial/mos7720.c
    @@ -1092,8 +1092,10 @@ static int mos7720_write(struct tty_stru
    if (urb->transfer_buffer == NULL) {
    urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
    GFP_ATOMIC);
    - if (!urb->transfer_buffer)
    + if (!urb->transfer_buffer) {
    + bytes_sent = -ENOMEM;
    goto exit;
    + }
    }
    transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE);


    \
     
     \ /
      Last update: 2021-03-02 14:40    [W:2.240 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site