lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 261/663] clk: meson: clk-pll: make "ret" a signed integer
    Date
    From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

    [ Upstream commit 9e717285f0bd591d716fa0e7418f2cdaf756dd25 ]

    The error codes returned by meson_clk_get_pll_settings() are all
    negative. Make "ret" a signed integer in meson_clk_pll_set_rate() to
    make it match with the clk_ops.set_rate API as well as the data type
    returned by meson_clk_get_pll_settings().

    Fixes: 8eed1db1adec6a ("clk: meson: pll: update driver for the g12a")
    Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
    Link: https://lore.kernel.org/r/20201226121556.975418-3-martin.blumenstingl@googlemail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/meson/clk-pll.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
    index 9404609b5ebfa..5b932976483fd 100644
    --- a/drivers/clk/meson/clk-pll.c
    +++ b/drivers/clk/meson/clk-pll.c
    @@ -365,8 +365,9 @@ static int meson_clk_pll_set_rate(struct clk_hw *hw, unsigned long rate,
    {
    struct clk_regmap *clk = to_clk_regmap(hw);
    struct meson_clk_pll_data *pll = meson_clk_pll_data(clk);
    - unsigned int enabled, m, n, frac = 0, ret;
    + unsigned int enabled, m, n, frac = 0;
    unsigned long old_rate;
    + int ret;

    if (parent_rate == 0 || rate == 0)
    return -EINVAL;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:40    [W:4.017 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site