lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 037/775] memory: mtk-smi: Fix PM usage counter unbalance in mtk_smi ops
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit a2d522ff0f5cc26915c4ccee9457fd4b4e1edc48 ]

    pm_runtime_get_sync will increment pm usage counter
    even it failed. Forgetting to putting operation will
    result in reference leak here. We fix it by replacing
    it with pm_runtime_resume_and_get to keep usage counter
    balanced.

    Fixes: 4f0a1a1ae3519 ("memory: mtk-smi: Invoke pm runtime_callback to enable clocks")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201123102118.3866195-1-zhangqilong3@huawei.com
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/mtk-smi.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
    index ac350f8d1e20f..82d09b88240e1 100644
    --- a/drivers/memory/mtk-smi.c
    +++ b/drivers/memory/mtk-smi.c
    @@ -130,7 +130,7 @@ static void mtk_smi_clk_disable(const struct mtk_smi *smi)

    int mtk_smi_larb_get(struct device *larbdev)
    {
    - int ret = pm_runtime_get_sync(larbdev);
    + int ret = pm_runtime_resume_and_get(larbdev);

    return (ret < 0) ? ret : 0;
    }
    @@ -374,7 +374,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
    int ret;

    /* Power on smi-common. */
    - ret = pm_runtime_get_sync(larb->smi_common_dev);
    + ret = pm_runtime_resume_and_get(larb->smi_common_dev);
    if (ret < 0) {
    dev_err(dev, "Failed to pm get for smi-common(%d).\n", ret);
    return ret;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:26    [W:3.907 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site