lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 297/663] power: supply: fix sbs-charger build, needs REGMAP_I2C
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit a4bdea2004b28f47ab48ea99172eda8628f6fb44 ]

    CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are
    provided by that Kconfig symbol.

    Fixes these errors:

    ../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type
    static const struct regmap_config sbs_regmap = {
    ../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’
    .reg_bits = 8,
    ../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function)
    .val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */
    ../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’:
    ../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration]
    chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap);
    ../drivers/power/supply/sbs-charger.c: At top level:
    ../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known
    static const struct regmap_config sbs_regmap = {

    Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
    Reported-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Tested-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/power/supply/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
    index eec646c568b7b..1699b9269a78e 100644
    --- a/drivers/power/supply/Kconfig
    +++ b/drivers/power/supply/Kconfig
    @@ -229,6 +229,7 @@ config BATTERY_SBS
    config CHARGER_SBS
    tristate "SBS Compliant charger"
    depends on I2C
    + select REGMAP_I2C
    help
    Say Y to include support for SBS compliant battery chargers.

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:10    [W:4.827 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site