lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 016/663] random: fix the RNDRESEEDCRNG ioctl
    Date
    From: Eric Biggers <ebiggers@google.com>

    commit 11a0b5e0ec8c13bef06f7414f9e914506140d5cb upstream.

    The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which
    doesn't make sense. Reseed it from the input_pool instead.

    Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG")
    Cc: stable@vger.kernel.org
    Cc: linux-crypto@vger.kernel.org
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Jann Horn <jannh@google.com>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Reviewed-by: Jann Horn <jannh@google.com>
    Acked-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Link: https://lore.kernel.org/r/20210112192818.69921-1-ebiggers@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/random.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -1972,7 +1972,7 @@ static long random_ioctl(struct file *f,
    return -EPERM;
    if (crng_init < 2)
    return -ENODATA;
    - crng_reseed(&primary_crng, NULL);
    + crng_reseed(&primary_crng, &input_pool);
    crng_global_init_time = jiffies - 1;
    return 0;
    default:

    \
     
     \ /
      Last update: 2021-03-02 02:40    [W:2.122 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site