Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 9 Feb 2021 16:49:37 +0100 | Subject | Re: [PATCH v10 7/7] at24: Support probing while off |
| |
On Mon, Feb 8, 2021 at 5:54 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Mon, Feb 8, 2021 at 5:44 PM Bartosz Golaszewski > <bgolaszewski@baylibre.com> wrote: > > > > On Fri, Feb 5, 2021 at 2:25 PM Sakari Ailus > > <sakari.ailus@linux.intel.com> wrote: > > > > > > In certain use cases (where the chip is part of a camera module, and the > > > camera module is wired together with a camera privacy LED), powering on > > > the device during probe is undesirable. Add support for the at24 to > > > execute probe while being powered off. For this to happen, a hint in form > > > of a device property is required from the firmware. > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > Reviewed-by: Tomasz Figa <tfiga@chromium.org> > > > --- > > > > I'll ack this but I still claim that the name > > acpi_dev_state_low_power() is super misleading for this use-case and > > I've been saying that for 10 versions now with everyone just ignoring > > my remarks. :/ > > Well, the function in question simply checks if the current ACPI power > state of the device is different from "full power", so its name > appears to be quite adequate to me. > > If the way in which it is used is confusing, though, I guess > explaining what's going on would be welcome. >
Yes, I have explained it multiple time already - last time at v9 of this series:
https://www.spinics.net/lists/kernel/msg3816807.html
Bartosz
> > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
| |