Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 8 Feb 2021 16:16:23 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/7] fsdax: Replace mmap entry in case of CoW |
| |
> static void *dax_insert_entry(struct xa_state *xas, > struct address_space *mapping, struct vm_fault *vmf, > - void *entry, pfn_t pfn, unsigned long flags, bool dirty) > + void *entry, pfn_t pfn, unsigned long flags, bool insert_flags) > { > void *new_entry = dax_make_entry(pfn, flags); > + bool dirty = insert_flags & DAX_IF_DIRTY; > + bool cow = insert_flags & DAX_IF_COW; > > if (dirty) > __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
Can we just move the __mark_inode_dirty to the one caller that needs it in a prep patch?
| ![\](/images/icornerr.gif) |