lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 27/65] usb: dwc3: fix clock issue during resume in OTG mode
    Date
    From: Gary Bisson <gary.bisson@boundarydevices.com>

    commit 0e5a3c8284a30f4c43fd81d7285528ece74563b5 upstream.

    Commit fe8abf332b8f ("usb: dwc3: support clocks and resets for DWC3
    core") introduced clock support and a new function named
    dwc3_core_init_for_resume() which enables the clock before calling
    dwc3_core_init() during resume as clocks get disabled during suspend.

    Unfortunately in this commit the DWC3_GCTL_PRTCAP_OTG case was forgotten
    and therefore during resume, a platform could call dwc3_core_init()
    without re-enabling the clocks first, preventing to resume properly.

    So update the resume path to call dwc3_core_init_for_resume() as it
    should.

    Fixes: fe8abf332b8f ("usb: dwc3: support clocks and resets for DWC3 core")
    Cc: stable@vger.kernel.org
    Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
    Link: https://lore.kernel.org/r/20210125161934.527820-1-gary.bisson@boundarydevices.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/dwc3/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/dwc3/core.c
    +++ b/drivers/usb/dwc3/core.c
    @@ -1718,7 +1718,7 @@ static int dwc3_resume_common(struct dwc
    if (PMSG_IS_AUTO(msg))
    break;

    - ret = dwc3_core_init(dwc);
    + ret = dwc3_core_init_for_resume(dwc);
    if (ret)
    return ret;


    \
     
     \ /
      Last update: 2021-02-08 17:35    [W:7.185 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site