lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 18/24] net: stmmac: dwc-qos: Use dev_err_probe() for probe errors handling
    Date
    There is a very handy dev_err_probe() method to handle the deferred probe
    error number. It reduces the code size and identations, uniforms error
    handling, records the defer probe reason, etc. Use it to print the probe
    callback error message.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Cc: Anson Huang <Anson.Huang@nxp.com>
    ---
    drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
    index 20b3696fb776..b71f0c3faebe 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
    @@ -466,10 +466,8 @@ static int dwc_eth_dwmac_probe(struct platform_device *pdev)

    ret = data->probe(pdev, plat_dat, &stmmac_res);
    if (ret < 0) {
    - if (ret != -EPROBE_DEFER)
    - dev_err(&pdev->dev, "failed to probe subdriver: %d\n",
    - ret);
    -
    + dev_err_probe(&pdev->dev, ret, "failed to probe subdriver: %d\n",
    + ret);
    goto remove_config;
    }

    --
    2.29.2
    \
     
     \ /
      Last update: 2021-02-08 15:15    [W:6.366 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site