Messages in this thread | | | Subject | Re: [PATCH] dax: fix default return code of range_parse() | From | Ruan Shiyang <> | Date | Mon, 8 Feb 2021 13:49:38 +0800 |
| |
ping
On 2021/1/26 上午10:13, Shiyang Ruan wrote: > The return value of range_parse() indicates the size when it is > positive. The error code should be negative. > > Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com> > --- > drivers/dax/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index 737b207c9e30..3003558c1a8b 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -1038,7 +1038,7 @@ static ssize_t range_parse(const char *opt, size_t len, struct range *range) > { > unsigned long long addr = 0; > char *start, *end, *str; > - ssize_t rc = EINVAL; > + ssize_t rc = -EINVAL; > > str = kstrdup(opt, GFP_KERNEL); > if (!str) >
| |