Messages in this thread | | | Subject | Re: [PATCH v2] kernel: Expose SYS_kcmp by default | From | Chris Wilson <> | Date | Fri, 05 Feb 2021 21:28:52 +0000 |
| |
Quoting Kees Cook (2021-02-05 21:20:33) > On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote: > > The subject should of course be changed, as it is no longer being > > enabled by default. > > "default n" is redundant.
I thought being explicit would be preferred. There are a few other default n, so at least it's not the odd-one-out!
> I thought Daniel said CONFIG_DRM needed to > "select" it too, though?
Yes. We will need to select it for any DRM driver so that the Vulkan/GL stacks can rely on having SYS_kcmp. That deserves to be handled and explain within drm/Kconfig, and as they are already shipping with calls to SYS_kcmp we may have to ask for a stable backport.
> Otherwise, yeah, this looks good. Was the > export due to the 0-day bot failure reports?
Yes. -Chris
| |