lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectAW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
Date
Hello Pavel,


> > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > > > index f13117eed976..4b40bf66483c 100644
> > > > --- a/drivers/leds/leds-lp50xx.c
> > > > +++ b/drivers/leds/leds-lp50xx.c
> > > > @@ -267,7 +267,6 @@ struct lp50xx_led {
> > > > struct led_classdev_mc mc_cdev;
> > > > struct lp50xx *priv;
> > > > unsigned long bank_modules;
> > > > - int led_intensity[LP50XX_LEDS_PER_MODULE];
> > > > u8 ctrl_bank_enabled;
> > > > int led_number;
> > > > };
> > >
> > > ? Does not make sense and changelog does not help.
> >
> > This is an unused variable which is in the driver
> > (same as the regulator). Should I provide a patch on its own for that
> > or just describe in the changelog?
>
> Lets do separate patch here. DT changes will need Ack from Rob, this
> can go in directly.

Okay, I will submit a separate patch

> Can you or Dan submit patch getting the regulator support to work? If
> not, I guess we should remove the regulator support after all.

To be true I am fairly new to the kernel and have no idea
how to test this. So no, I don't want provide a patch (except
for removing), sorry.

Best Regards,

Sven


\
 
 \ /
  Last update: 2021-02-05 12:39    [W:0.205 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site