Messages in this thread | | | From | Saravana Kannan <> | Date | Thu, 4 Feb 2021 18:07:53 -0800 | Subject | Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE |
| |
On Thu, Feb 4, 2021 at 5:54 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Saravana, > > On Thu, Feb 4, 2021 at 10:39 PM Saravana Kannan <saravanak@google.com> wrote: > > > > Using IRQCHIP_DECLARE lets fw_devlink know that it should not wait for > > these interrupt controllers to be populated as struct devices. Without > > this change, fw_devlink=on will make the consumers of these interrupt > > controllers wait for the struct device to be added and thereby block the > > consumers' probes forever. Converting to IRQCHIP_DECLARE addresses boot > > issues on imx25 with fw_devlink=on that were reported by Martin. > > > > This also removes a lot of boilerplate code. > > > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > > Reported-by: Martin Kaiser <martin@kaiser.cx> > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > Tested-by: Martin Kaiser <martin@kaiser.cx> > > Thanks for the respin: > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks for the quick review.
-Saravana
| |