lkml.org 
[lkml]   [2021]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver
From
Date
Hi Ben,

On 2/3/21 02:50, Benjamin Li wrote:
> On 1/5/21 5:54 AM, Georgi Djakov wrote:
>> On 1/2/21 13:08, Vincent Knecht wrote:
>>> Le vendredi 04 décembre 2020 à 15:53 +0800, Jun Nie a écrit :
>>>> Add driver for the Qualcomm interconnect buses found in MSM8939 based
>>>> platforms. The topology consists of four NoCs that are controlled by
>>>> a remote processor that collects the aggregated bandwidth for each
>>>> master-slave pairs.
>>>>
>>>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>>>
>>> Shouldn't some rpm ids be changed like they were for msm8916 in the following patch ?
>>> c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes")
>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20201112105140.10092-1-georgi.djakov@linaro.org/
>>
>> Maybe they should. I don't have the hardware to try it, but the test will be
>> to just add the NoC DT nodes, enable the driver and inspect the boot log for
>> messages like:
>> [    2.926647] qcom_icc_rpm_smd_send mas X error -6
>>
>> Thanks,
>> Georgi
>
> Hi Vincent & Georgi,
>
> Thanks, I ran your suggestion on an MSM8939 board (with an additional
> change to print slave IDs as well). Results:
>
> [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6
> [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6
> [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6
> [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6
> [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6
> [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6
> [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6
> [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6
> (and there's another slv 131 that's hidden by the mas 100 failure)
>
> Jun, I'll send you the patch I tested with to silence all these errors,
> if you want to just squash that into the next version of your patchset.

Thank you for doing this! Please send a follow-up patch as i already
queued Jun's patches.

Thanks,
Georgi

\
 
 \ /
  Last update: 2021-02-03 07:52    [W:0.040 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site